James M. McDonald, picked for U.S. attorney for New York’s Southern District, would succeed Jay Clayton, whom the president named director of national intelligence.